You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/02/13 14:27:50 UTC

[GitHub] [nifi-minifi-cpp] arpadboda opened a new pull request #738: MINIFICPP-1161 - Build and test more extensions in CI (Xenial build)

arpadboda opened a new pull request #738: MINIFICPP-1161 - Build and test more extensions in CI (Xenial build)
URL: https://github.com/apache/nifi-minifi-cpp/pull/738
 
 
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #738: MINIFICPP-1161 - Build and test more extensions in CI (Xenial build)

Posted by GitBox <gi...@apache.org>.
arpadboda commented on a change in pull request #738: MINIFICPP-1161 - Build and test more extensions in CI (Xenial build)
URL: https://github.com/apache/nifi-minifi-cpp/pull/738#discussion_r378960707
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -97,35 +97,42 @@ matrix:
       name: xenial shared build with tests
       dist: xenial
       sudo: required
+      addons:
+        apt:
+          sources:
+          - ubuntu-toolchain-r-test
+          packages:
+          - openjdk-8-jdk
+          - maven
       script:
-        - ./bootstrap.sh -e -t && cd build  && cmake -DUSE_SHARED_LIBS= .. &&  cmake --build . --parallel 4  && sudo make test ARGS="-j4 --output-on-failure"
+        - ./bootstrap.sh -e -t && cd build  && cmake -DUSE_SHARED_LIBS= -DENABLE_LIBRDKAFKA=ON -DENABLE_OPC=ON -DENABLE_SFTP=ON -DENABLE_MQTT=ON -DENABLE_COAP-ON .. &&  cmake --build . --parallel 4  && sudo make test ARGS="-j4 --output-on-failure"
 
 Review comment:
   Thanks, fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #738: MINIFICPP-1161 - Build and test more extensions in CI (Xenial build)

Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #738: MINIFICPP-1161 - Build and test more extensions in CI (Xenial build)
URL: https://github.com/apache/nifi-minifi-cpp/pull/738#discussion_r378955955
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -97,35 +97,42 @@ matrix:
       name: xenial shared build with tests
       dist: xenial
       sudo: required
+      addons:
+        apt:
+          sources:
+          - ubuntu-toolchain-r-test
+          packages:
+          - openjdk-8-jdk
+          - maven
       script:
-        - ./bootstrap.sh -e -t && cd build  && cmake -DUSE_SHARED_LIBS= .. &&  cmake --build . --parallel 4  && sudo make test ARGS="-j4 --output-on-failure"
+        - ./bootstrap.sh -e -t && cd build  && cmake -DUSE_SHARED_LIBS= -DENABLE_LIBRDKAFKA=ON -DENABLE_OPC=ON -DENABLE_SFTP=ON -DENABLE_MQTT=ON -DENABLE_COAP-ON .. &&  cmake --build . --parallel 4  && sudo make test ARGS="-j4 --output-on-failure"
     - os: linux
       name: debian static package build
-      dist: trusty
+      dist: bionic
 
 Review comment:
   The PR title says xenial. I'm fine with bionic btw.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #738: MINIFICPP-1161 - Build and test more extensions in CI (Xenial build)

Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #738: MINIFICPP-1161 - Build and test more extensions in CI (Xenial build)
URL: https://github.com/apache/nifi-minifi-cpp/pull/738#discussion_r378955681
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -97,35 +97,42 @@ matrix:
       name: xenial shared build with tests
       dist: xenial
       sudo: required
+      addons:
+        apt:
+          sources:
+          - ubuntu-toolchain-r-test
+          packages:
+          - openjdk-8-jdk
+          - maven
       script:
-        - ./bootstrap.sh -e -t && cd build  && cmake -DUSE_SHARED_LIBS= .. &&  cmake --build . --parallel 4  && sudo make test ARGS="-j4 --output-on-failure"
+        - ./bootstrap.sh -e -t && cd build  && cmake -DUSE_SHARED_LIBS= -DENABLE_LIBRDKAFKA=ON -DENABLE_OPC=ON -DENABLE_SFTP=ON -DENABLE_MQTT=ON -DENABLE_COAP-ON .. &&  cmake --build . --parallel 4  && sudo make test ARGS="-j4 --output-on-failure"
 
 Review comment:
   typo: s/ENABLE_COAP-ON/ENABLE_COAP=ON/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #738: MINIFICPP-1161 - Build and test more extensions in CI (Xenial build)

Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #738: MINIFICPP-1161 - Build and test more extensions in CI (Xenial build)
URL: https://github.com/apache/nifi-minifi-cpp/pull/738#discussion_r378955955
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -97,35 +97,42 @@ matrix:
       name: xenial shared build with tests
       dist: xenial
       sudo: required
+      addons:
+        apt:
+          sources:
+          - ubuntu-toolchain-r-test
+          packages:
+          - openjdk-8-jdk
+          - maven
       script:
-        - ./bootstrap.sh -e -t && cd build  && cmake -DUSE_SHARED_LIBS= .. &&  cmake --build . --parallel 4  && sudo make test ARGS="-j4 --output-on-failure"
+        - ./bootstrap.sh -e -t && cd build  && cmake -DUSE_SHARED_LIBS= -DENABLE_LIBRDKAFKA=ON -DENABLE_OPC=ON -DENABLE_SFTP=ON -DENABLE_MQTT=ON -DENABLE_COAP-ON .. &&  cmake --build . --parallel 4  && sudo make test ARGS="-j4 --output-on-failure"
     - os: linux
       name: debian static package build
-      dist: trusty
+      dist: bionic
 
 Review comment:
   The PR title says xenial. I'm fine with bionic btw.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #738: MINIFICPP-1161 - Build and test more extensions in CI (Xenial build)

Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #738: MINIFICPP-1161 - Build and test more extensions in CI (Xenial build)
URL: https://github.com/apache/nifi-minifi-cpp/pull/738
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services