[GitHub] [airflow] tooptoop4 commented on a change in pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

[GitBox <gi...@apache.org>]

tooptoop4 commented on a change in pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#discussion_r389944161
 
 

 ##########
 File path: airflow/migrations/versions/b25a55525161_increase_length_of_pool_name.py
 ##########
 @@ -0,0 +1,48 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Increase length of pool name
+
+Revision ID: b25a55525161
+Revises: a4c2fd67d16b
+Create Date: 2020-03-09 08:48:14.534700
+
+"""
+
+import sqlalchemy as sa
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision = 'b25a55525161'
+down_revision = 'a4c2fd67d16b'
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    """Increase column length of pool name from 50 to 250 characters"""
 
 Review comment:
   256 instead of 250

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services