You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/07 06:22:36 UTC
[GitHub] [tvm] junrushao1994 opened a new pull request, #10927: [MetaSchedule][Refactor] Clarify Integration Logic
junrushao1994 opened a new pull request, #10927:
URL: https://github.com/apache/tvm/pull/10927
Based on @masahi's PR #10578, we are able to further simplify the logic and remove redundancy.
Changes:
- Remove `MetaScheduleContext`, which is not useful any more after Masa's new relay backend;
- Consolidate logic around `ApplyHistoryBest`, and slightly improve the error message;
- Separate `integration.py` into 3 files: `apply_history_best.py`, `extracted_task.py` and `relay_integration.py`;
These changes make future Relax integration easier - the only thing needed is to add `relax_integration.py` without having to worry about potential conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #10927: [MetaSchedule][Refactor] Clarify Integration Logic
Posted by GitBox <gi...@apache.org>.
masahi merged PR #10927:
URL: https://github.com/apache/tvm/pull/10927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #10927: [MetaSchedule][Refactor] Clarify Integration Logic
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #10927:
URL: https://github.com/apache/tvm/pull/10927#issuecomment-1091892083
@sunggg Thanks for asking!
There is no breaking change in terms of API usage, given ApplyHistoryBest is the only framework-facing integration point. It's still used in the same way like:
```python
with ApplyHistoryBest(database=...):
...
```
`MetaScheduleContext` is no longer in use after @masahi's refactoring in both Relay (https://github.com/apache/tvm/pull/10578) and Relax (https://github.com/tlc-pack/relax/pull/92), so it makes sense to just remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sunggg commented on pull request #10927: [MetaSchedule][Refactor] Clarify Integration Logic
Posted by GitBox <gi...@apache.org>.
sunggg commented on PR #10927:
URL: https://github.com/apache/tvm/pull/10927#issuecomment-1091888842
Overall, LGTM.
One quick question - it seems like this PR replaces MetaScheduleContext to ApplyHistoryBestContext?
Does it mean other functionalities, like tuning, does not need any contextual information?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #10927: [MetaSchedule][Refactor] Clarify Integration Logic
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #10927:
URL: https://github.com/apache/tvm/pull/10927#issuecomment-1091124797
CC: @YuchenJin @masahi @zxybazh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #10927: [MetaSchedule][Refactor] Clarify Integration Logic
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #10927:
URL: https://github.com/apache/tvm/pull/10927#issuecomment-1091893884
> Does it mean other functionalities, like tuning, does not need any contextual information?
@sunggg For now, `MetaScheduleContext` doesn't support providing arbitrary contextual information, so removing it doesn't bring in any regression. In the future, we will need to think very seriously about what the best API design is in terms of supplying arbitrary contextual information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sunggg commented on pull request #10927: [MetaSchedule][Refactor] Clarify Integration Logic
Posted by GitBox <gi...@apache.org>.
sunggg commented on PR #10927:
URL: https://github.com/apache/tvm/pull/10927#issuecomment-1091895472
@junrushao1994 Thank you for the explanation. Makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org