You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Ben Anderson <be...@benanderson.us> on 2004/09/29 14:13:04 UTC
[JELLY] LoopTagStatus done
Hi,
It turns out I'm blocked from getting to jira here at work, so I guess I have to
post this patch here. This concerns jelly-150 in jira. I had attempted to fix
the LoopTagStatus feature (which is described in the jira entry), but was
unsuccesful. I played with it a little more, and it seems to be working fine
now. I was using an anonymous inner class which extended Object. I changed it
so that the anon. inner class now implements LoopTagStatus. This is an
interface which needed to be added to the project. I actually just took it out
of the standard taglibs project. This is fine, right? I made the test a
little more robust as well, which ended up catching a bug. The "end" attribute
should be inclusive, but it was being exclusive. Anyways, I don't think I can
inline the patch in this email, because I'm using web-email. And I don't think
attachments make it through list, do they? I'll put the patch here:
http://www.benanderson.us/bd/forEach2.patch
I'll also post it to jira when I get home. So, I'm just curious - how long does
it usually take to be included?
Thanks,
Ben
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [JELLY] LoopTagStatus done
Posted by Ben Anderson <be...@benanderson.us>.
great - thanks!
Dion Gillard wrote:
>How long?
>
>It depends. At least a few days usually until someone gets to it, and
>that's if it's all fine and dandy.
>
>Will check it out as soon as I can.
>
>
>On Wed, 29 Sep 2004 05:13:04 -0700, Ben Anderson
><be...@benanderson.us> wrote:
>
>
>>Hi,
>>It turns out I'm blocked from getting to jira here at work, so I guess I have to
>>post this patch here. This concerns jelly-150 in jira. I had attempted to fix
>>the LoopTagStatus feature (which is described in the jira entry), but was
>>unsuccesful. I played with it a little more, and it seems to be working fine
>>now. I was using an anonymous inner class which extended Object. I changed it
>>so that the anon. inner class now implements LoopTagStatus. This is an
>>interface which needed to be added to the project. I actually just took it out
>>of the standard taglibs project. This is fine, right? I made the test a
>>little more robust as well, which ended up catching a bug. The "end" attribute
>>should be inclusive, but it was being exclusive. Anyways, I don't think I can
>>inline the patch in this email, because I'm using web-email. And I don't think
>>attachments make it through list, do they? I'll put the patch here:
>>http://www.benanderson.us/bd/forEach2.patch
>>I'll also post it to jira when I get home. So, I'm just curious - how long does
>>it usually take to be included?
>>Thanks,
>>Ben
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
>>
>>
>>
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [JELLY] LoopTagStatus done
Posted by Dion Gillard <di...@gmail.com>.
How long?
It depends. At least a few days usually until someone gets to it, and
that's if it's all fine and dandy.
Will check it out as soon as I can.
On Wed, 29 Sep 2004 05:13:04 -0700, Ben Anderson
<be...@benanderson.us> wrote:
> Hi,
> It turns out I'm blocked from getting to jira here at work, so I guess I have to
> post this patch here. This concerns jelly-150 in jira. I had attempted to fix
> the LoopTagStatus feature (which is described in the jira entry), but was
> unsuccesful. I played with it a little more, and it seems to be working fine
> now. I was using an anonymous inner class which extended Object. I changed it
> so that the anon. inner class now implements LoopTagStatus. This is an
> interface which needed to be added to the project. I actually just took it out
> of the standard taglibs project. This is fine, right? I made the test a
> little more robust as well, which ended up catching a bug. The "end" attribute
> should be inclusive, but it was being exclusive. Anyways, I don't think I can
> inline the patch in this email, because I'm using web-email. And I don't think
> attachments make it through list, do they? I'll put the patch here:
> http://www.benanderson.us/bd/forEach2.patch
> I'll also post it to jira when I get home. So, I'm just curious - how long does
> it usually take to be included?
> Thanks,
> Ben
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
--
http://www.multitask.com.au/people/dion/
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org