You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2011/12/15 20:24:02 UTC

Re: Review Request: HIVE-2544: Nullpointer on registering udfs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2702/#review3927
-----------------------------------------------------------



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/2702/#comment8870>

    Is it possible to write a test case, which spins 10s of threads doing operations. Thats not fool-proof but will result in some coverage. Unless you have a better idea for writing test case for this.



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/2702/#comment8869>

    Its LinkedHashMap right now, changing it to Concurrent will violate the contract of LinkedHashMap which you can iterate in same order as your inserts.  Not sure if violating that is alright here.


- Ashutosh


On 2011-11-03 13:47:48, Bennie Schut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2702/
> -----------------------------------------------------------
> 
> (Updated 2011-11-03 13:47:48)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> HIVE-2544: Nullpointer on registering udfs.
> 
> 
> This addresses bug HIVE-2544.
>     https://issues.apache.org/jira/browse/HIVE-2544
> 
> 
> Diffs
> -----
> 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1196618 
> 
> Diff: https://reviews.apache.org/r/2702/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bennie
> 
>