[GitHub] ustcweizhou commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

[gi...@git.apache.org]

ustcweizhou commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#discussion_r117527984
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##########
 @@ -2725,14 +2725,14 @@ public String rebootVM(final Connect conn, final String vmName) {
         return msg;
     }
 
-    public String stopVM(final Connect conn, final String vmName) {
+    public String stopVM(final Connect conn, final String vmName, final boolean forceStop) {
         DomainState state = null;
         Domain dm = null;
 
         s_logger.debug("Try to stop the vm at first");
-        String ret = stopVM(conn, vmName, false);
+        String ret = stopVMInternal(conn, vmName, forceStop);
 
 Review comment:
   @rhtyd 
   can line 2733 be changed to the following ?
   ```
   if (forceStop)
       return stopVMInternal(conn, vmName, forceStop);
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services