You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bartek Plotka <bw...@gmail.com> on 2015/05/28 04:35:22 UTC
Review Request 34748: Defined protobuf for usage returned by Resource
Monitor. Reused ResourceUsage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/
-----------------------------------------------------------
Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
Bugs: MESOS-2772
https://issues.apache.org/jira/browse/MESOS-2772
Repository: mesos
Description
-------
Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
Reused old ResoureUsage in message mesos.proto
NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
Discussed that ResourceUsage message proto is free to reuse and modify, since it's not use anywhere else.
Diffs
-----
include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
Diff: https://reviews.apache.org/r/34748/diff/
Testing
-------
make check
Thanks,
Bartek Plotka
Re: Review Request 34748: Defined protobuf for usage returned by
Resource
Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review85965
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34816, 34662, 34748]
All tests passed.
- Mesos ReviewBot
On June 1, 2015, 8:31 a.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34748/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 8:31 a.m.)
>
>
> Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2772
> https://issues.apache.org/jira/browse/MESOS-2772
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
> Reused old ResoureUsage in message mesos.proto
>
> NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
> Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
> src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
> src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
>
> Diff: https://reviews.apache.org/r/34748/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34748: Defined protobuf for usage returned by
Resource
Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/
-----------------------------------------------------------
(Updated June 1, 2015, 8:31 a.m.)
Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
Changes
-------
Addressed the issue.
Bugs: MESOS-2772
https://issues.apache.org/jira/browse/MESOS-2772
Repository: mesos
Description
-------
Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
Reused old ResoureUsage in message mesos.proto
NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else.
Diffs (updated)
-----
include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
Diff: https://reviews.apache.org/r/34748/diff/
Testing
-------
make check
Thanks,
Bartek Plotka
Re: Review Request 34748: Defined protobuf for usage returned by
Resource
Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/
-----------------------------------------------------------
(Updated June 1, 2015, 8:15 a.m.)
Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
Changes
-------
Extended description.
Bugs: MESOS-2772
https://issues.apache.org/jira/browse/MESOS-2772
Repository: mesos
Description
-------
Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
Reused old ResoureUsage in message mesos.proto
NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else.
Diffs (updated)
-----
include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
Diff: https://reviews.apache.org/r/34748/diff/
Testing
-------
make check
Thanks,
Bartek Plotka
Re: Review Request 34748: Defined protobuf for usage returned by
Resource
Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review85601
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34662, 34748]
All tests passed.
- Mesos ReviewBot
On May 28, 2015, 6:41 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34748/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 6:41 p.m.)
>
>
> Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2772
> https://issues.apache.org/jira/browse/MESOS-2772
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
> Reused old ResoureUsage in message mesos.proto
>
> NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
> Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
> src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
> src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
>
> Diff: https://reviews.apache.org/r/34748/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34748: Defined protobuf for usage returned by
Resource
Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/
-----------------------------------------------------------
(Updated May 28, 2015, 6:41 p.m.)
Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
Changes
-------
This patch is depended on RE modularization.
Summary (updated)
-----------------
Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator
Bugs: MESOS-2772
https://issues.apache.org/jira/browse/MESOS-2772
Repository: mesos
Description
-------
Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
Reused old ResoureUsage in message mesos.proto
NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else.
Diffs
-----
include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
Diff: https://reviews.apache.org/r/34748/diff/
Testing
-------
make check
Thanks,
Bartek Plotka
Re: Review Request 34748: Defined protobuf for usage returned by
Resource
Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator
Posted by Bartek Plotka <bw...@gmail.com>.
> On May 28, 2015, 6:12 p.m., Niklas Nielsen wrote:
> > This will change the resource estimator patch set too - do you want to make them dependent on this one?
This patch depents on Resource Estimator modularization. (:
- Bartek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review85585
-----------------------------------------------------------
On May 28, 2015, 6:41 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34748/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 6:41 p.m.)
>
>
> Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2772
> https://issues.apache.org/jira/browse/MESOS-2772
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
> Reused old ResoureUsage in message mesos.proto
>
> NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
> Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
> src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
> src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
>
> Diff: https://reviews.apache.org/r/34748/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34748: Defined protobuf for usage returned by
Resource Monitor. Reused ResourceUsage.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review85585
-----------------------------------------------------------
This will change the resource estimator patch set too - do you want to make them dependent on this one?
include/mesos/mesos.proto
<https://reviews.apache.org/r/34748/#comment137169>
Let's scratch these - it's a public API, so let's describe how to interpret them instead.
- Niklas Nielsen
On May 27, 2015, 7:37 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34748/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 7:37 p.m.)
>
>
> Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2772
> https://issues.apache.org/jira/browse/MESOS-2772
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
> Reused old ResoureUsage in message mesos.proto
>
> NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
> Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
> src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
> src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
>
> Diff: https://reviews.apache.org/r/34748/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34748: Defined protobuf for usage returned by
Resource Monitor. Reused ResourceUsage.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review85541
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34748]
All tests passed.
- Mesos ReviewBot
On May 28, 2015, 2:37 a.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34748/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 2:37 a.m.)
>
>
> Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2772
> https://issues.apache.org/jira/browse/MESOS-2772
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
> Reused old ResoureUsage in message mesos.proto
>
> NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
> Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
> src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
> src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
>
> Diff: https://reviews.apache.org/r/34748/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34748: Defined protobuf for usage returned by
Resource Monitor. Reused ResourceUsage.
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/
-----------------------------------------------------------
(Updated May 28, 2015, 2:37 a.m.)
Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
Bugs: MESOS-2772
https://issues.apache.org/jira/browse/MESOS-2772
Repository: mesos
Description (updated)
-------
Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
Reused old ResoureUsage in message mesos.proto
NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else.
Diffs
-----
include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
Diff: https://reviews.apache.org/r/34748/diff/
Testing
-------
make check
Thanks,
Bartek Plotka