You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/24 02:34:28 UTC
[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #7402: drivers/modem/alt1250: Fix poll function
SPRESENSE opened a new pull request, #7402:
URL: https://github.com/apache/incubator-nuttx/pull/7402
## Summary
Notify only when there are available events.
## Impact
modem/alt1250 only
## Testing
spresense lte works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] SPRESENSE commented on a diff in pull request #7402: drivers/modem/alt1250: Fix poll function
Posted by GitBox <gi...@apache.org>.
SPRESENSE commented on code in PR #7402:
URL: https://github.com/apache/incubator-nuttx/pull/7402#discussion_r1002896707
##########
drivers/modem/alt1250/alt1250.c:
##########
@@ -279,6 +279,25 @@ static void write_evtbitmapwithlist(FAR struct alt1250_dev_s *dev,
nxmutex_unlock(&dev->evtmaplock);
}
+/****************************************************************************
+ * Name: is_evtbitmap_avail
+ ****************************************************************************/
+
+static int is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
Review Comment:
Fix with https://github.com/apache/incubator-nuttx/pull/7408
##########
drivers/modem/alt1250/alt1250.c:
##########
@@ -279,6 +279,25 @@ static void write_evtbitmapwithlist(FAR struct alt1250_dev_s *dev,
nxmutex_unlock(&dev->evtmaplock);
}
+/****************************************************************************
+ * Name: is_evtbitmap_avail
+ ****************************************************************************/
+
+static int is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
+{
+ int ret;
Review Comment:
Fix with https://github.com/apache/incubator-nuttx/pull/7408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7402: drivers/modem/alt1250: Fix poll function
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7402:
URL: https://github.com/apache/incubator-nuttx/pull/7402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7402: drivers/modem/alt1250: Fix poll function
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7402:
URL: https://github.com/apache/incubator-nuttx/pull/7402#discussion_r1002886204
##########
drivers/modem/alt1250/alt1250.c:
##########
@@ -279,6 +279,25 @@ static void write_evtbitmapwithlist(FAR struct alt1250_dev_s *dev,
nxmutex_unlock(&dev->evtmaplock);
}
+/****************************************************************************
+ * Name: is_evtbitmap_avail
+ ****************************************************************************/
+
+static int is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
Review Comment:
```suggestion
static bool is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
```
##########
drivers/modem/alt1250/alt1250.c:
##########
@@ -279,6 +279,25 @@ static void write_evtbitmapwithlist(FAR struct alt1250_dev_s *dev,
nxmutex_unlock(&dev->evtmaplock);
}
+/****************************************************************************
+ * Name: is_evtbitmap_avail
+ ****************************************************************************/
+
+static int is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
+{
+ int ret;
Review Comment:
```suggestion
bool ret;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org