You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by MLnick <gi...@git.apache.org> on 2018/01/16 07:51:47 UTC

[GitHub] spark pull request #17280: [SPARK-19939] [ML] Add support for association ru...

Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17280#discussion_r161679593
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
    @@ -319,9 +323,11 @@ object FPGrowthModel extends MLReadable[FPGrowthModel] {
     
         override def load(path: String): FPGrowthModel = {
           val metadata = DefaultParamsReader.loadMetadata(path, sc, className)
    +      implicit val format = DefaultFormats
    +      val numTrainingRecords = (metadata.metadata \ "numTrainingRecords").extract[Long]
    --- End diff --
    
    Does this break backward compatibility for loading?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org