[GitHub] [ignite-3] zstan commented on a diff in pull request #2527: IGNITE-18784 Fix tests for Windows

["zstan (via GitHub)" <gi...@apache.org>]

zstan commented on code in PR #2527:
URL: https://github.com/apache/ignite-3/pull/2527#discussion_r1312731135


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/QueryTaskExecutorImpl.java:
##########
@@ -54,7 +55,7 @@ public QueryTaskExecutorImpl(String nodeName) {
     public void start() {
         this.stripedThreadPoolExecutor = new StripedThreadPoolExecutor(
                 4,
-                NamedThreadFactory.threadPrefix(nodeName, "sql-execution-pool"),
+                NamedThreadFactory.threadPrefix(nodeName, "sql-execution-pool" + new Random().nextInt()),

Review Comment:
   I see NamedThreadFactory already have counter, why do we need also random here ?
   ```
       @Override
       public Thread newThread(Runnable r) {
           Thread t = new Thread(r);
   
           t.setDaemon(this.daemon);
           t.setUncaughtExceptionHandler(exHnd);
           t.setName(this.prefix + counter.getAndIncrement());
   
           return t;
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org