You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dylin <gi...@git.apache.org> on 2014/06/20 00:54:29 UTC
[GitHub] cordova-lib pull request: Fixed issue: CB-6140
GitHub user dylin opened a pull request:
https://github.com/apache/cordova-lib/pull/38
Fixed issue: CB-6140
plugman dependency check will ignore platform/dependecy when removing an
intalled plugin, which will result in platform level dependencies is
uninstalled inproperly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dylin/cordova-lib dylin/CB-6140
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 3241f0776efe9f9bcb3a5d09dedb3cba21c8a5dc
Author: Danyi Lin <da...@blackberry.com>
Date: 2014-06-19T22:45:19Z
Fixed issue: CB-6140
plugman dependency check will ignore platform/dependecy when removing an
intalled plugin, which will result in platform level dependencies is
uninstalled inproperly.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: [CB-6140] Don't allow deletion of platfo...
Posted by kamrik <gi...@git.apache.org>.
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/38#issuecomment-46700279
Merged it. But it would be awesome if at this opportunity you could also replace the direct XML parsing of the plugin.xml with PluginInfo object and PluginInfo.getDependencies(platform) which, I think, already does the right thing, though it looks under current platform rather than all the platforms.
PluginInfo usage examples can be found in plubman/insatll.js
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: Fixed issue: CB-6140
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/pull/38#issuecomment-46627998
1. The first line of your commit message should be of the form:
CB-6140 Don't allow deletion of platform dependencies
2. Please fix any misspellings in the commit message:
platform/dependecy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: [CB-6140] Don't allow deletion of platfo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---