[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #7358:
URL: https://github.com/apache/iceberg/pull/7358#discussion_r1171793456


##########
aws/src/integration/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -379,6 +379,21 @@ public void testRegisterTable() {
     Assertions.assertThat(catalog.dropNamespace(namespace)).isTrue();
   }
 
+  @Test
+  public void testDefaultWarehousePathWithLocation() {

Review Comment:
   +1 for adding a unit test, @munendrasn let me know if you could add that as suggested, other things looks good to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org