[GitHub] [systemds] mboehm7 commented on pull request #1421: [SYSTEMDS-3185] Federated Lookup Table

[GitBox <gi...@apache.org>]

mboehm7 commented on pull request #1421:
URL: https://github.com/apache/systemds/pull/1421#issuecomment-996242254


   LGTM - this is a great start toward multi-tenant federated learning where multiple data scientists (coordinators) are properly isolated at the federated sites.
   
   Initially the tests did not work for me because the wait for process completion ran into a blocking state due to filled up queues. After reimplementing how we obtain the output before going into wait state this issues was resolved. However, there still seems to be an issue:
   
   ```
   org.apache.spark.SparkException: A master URL must be set in your configuration
   	at org.apache.spark.SparkContext.<init>(SparkContext.scala:380)
   ```
   
   because the `DMLScript.USE_LOCAL_SPARK_CONFIG` is still set to false in the spawned coordinator processes. Could you have a look - maybe a new SystemDS-config property could do the trick? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org