You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/25 13:53:49 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #1606: Fix #1602 Speed up the CI
ppalaga opened a new pull request #1606:
URL: https://github.com/apache/camel-quarkus/pull/1606
Fix #1602
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1606: Fix #1602 Speed up the CI
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1606:
URL: https://github.com/apache/camel-quarkus/pull/1606#discussion_r476519604
##########
File path: .github/workflows/ci-build.yaml
##########
@@ -151,14 +150,101 @@ jobs:
df -h /
tar -xzf ../maven-repo.tgz -C ~
df -h /
- - name: Build on ${{ matrix.java }}
+ - name: cd extensions-core && mvn test
run: |
- ./mvnw -V -ntp ${BRANCH_OPTIONS} \
- clean verify
- - name: Fail if there are uncommitted changes
+ cd extensions-core
+ ../mvnw -V -ntp ${BRANCH_OPTIONS} \
+ -Dformatter.skip -Dimpsort.skip -Denforce=false -Dcamel-quarkus.update-extension-doc-page.skip \
Review comment:
Yeah, that sounds like a valid use case. Would you mind creating a followup issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #1606: Fix #1602 Speed up the CI
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1606:
URL: https://github.com/apache/camel-quarkus/pull/1606#discussion_r476525156
##########
File path: .github/workflows/ci-build.yaml
##########
@@ -151,14 +150,101 @@ jobs:
df -h /
tar -xzf ../maven-repo.tgz -C ~
df -h /
- - name: Build on ${{ matrix.java }}
+ - name: cd extensions-core && mvn test
run: |
- ./mvnw -V -ntp ${BRANCH_OPTIONS} \
- clean verify
- - name: Fail if there are uncommitted changes
+ cd extensions-core
+ ../mvnw -V -ntp ${BRANCH_OPTIONS} \
+ -Dformatter.skip -Dimpsort.skip -Denforce=false -Dcamel-quarkus.update-extension-doc-page.skip \
Review comment:
https://github.com/apache/camel-quarkus/issues/1607
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1606: Fix #1602 Speed up the CI
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1606:
URL: https://github.com/apache/camel-quarkus/pull/1606#discussion_r476500120
##########
File path: .github/workflows/ci-build.yaml
##########
@@ -151,14 +150,101 @@ jobs:
df -h /
tar -xzf ../maven-repo.tgz -C ~
df -h /
- - name: Build on ${{ matrix.java }}
+ - name: cd extensions-core && mvn test
run: |
- ./mvnw -V -ntp ${BRANCH_OPTIONS} \
- clean verify
- - name: Fail if there are uncommitted changes
+ cd extensions-core
+ ../mvnw -V -ntp ${BRANCH_OPTIONS} \
+ -Dformatter.skip -Dimpsort.skip -Denforce=false -Dcamel-quarkus.update-extension-doc-page.skip \
Review comment:
Hm... I am a bit undecided, what should be there in `-Dquickly`. I tend to think that most of times when I want to build quickly, `-Dformatter.skip -Dimpsort.skip -Denforce=false -Dcamel-quarkus.update-extension-doc-page.skip` should not be there, because in that way, I'd end up with unformated source tree with bad deps and stale docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #1606: Fix #1602 Speed up the CI
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1606:
URL: https://github.com/apache/camel-quarkus/pull/1606
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1606: Fix #1602 Speed up the CI
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1606:
URL: https://github.com/apache/camel-quarkus/pull/1606#issuecomment-680069017
The initial build went from ~49min down to ~17min - that's great!
Compare with this recent job: https://github.com/apache/camel-quarkus/pull/1595/checks?check_run_id=1025749383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #1606: Fix #1602 Speed up the CI
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1606:
URL: https://github.com/apache/camel-quarkus/pull/1606#discussion_r476512634
##########
File path: .github/workflows/ci-build.yaml
##########
@@ -151,14 +150,101 @@ jobs:
df -h /
tar -xzf ../maven-repo.tgz -C ~
df -h /
- - name: Build on ${{ matrix.java }}
+ - name: cd extensions-core && mvn test
run: |
- ./mvnw -V -ntp ${BRANCH_OPTIONS} \
- clean verify
- - name: Fail if there are uncommitted changes
+ cd extensions-core
+ ../mvnw -V -ntp ${BRANCH_OPTIONS} \
+ -Dformatter.skip -Dimpsort.skip -Denforce=false -Dcamel-quarkus.update-extension-doc-page.skip \
Review comment:
It depends on what you want to achieve i.e. if you check out master and you want a quick way to install everything because you are working on a side project that depends on latest camel-quarkus bits, you don't care about formatting or stale docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1606: Fix #1602 Speed up the CI
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1606:
URL: https://github.com/apache/camel-quarkus/pull/1606#discussion_r476472240
##########
File path: .github/workflows/ci-build.yaml
##########
@@ -151,14 +150,101 @@ jobs:
df -h /
tar -xzf ../maven-repo.tgz -C ~
df -h /
- - name: Build on ${{ matrix.java }}
+ - name: cd extensions-core && mvn test
run: |
- ./mvnw -V -ntp ${BRANCH_OPTIONS} \
- clean verify
- - name: Fail if there are uncommitted changes
+ cd extensions-core
+ ../mvnw -V -ntp ${BRANCH_OPTIONS} \
+ -Dformatter.skip -Dimpsort.skip -Denforce=false -Dcamel-quarkus.update-extension-doc-page.skip \
Review comment:
Maybe we could look at doing what Quarkus does and combine most of these under a `quickly` profile. E.g `mvn clean install -Dquickly`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #1606: Fix #1602 Speed up the CI
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1606:
URL: https://github.com/apache/camel-quarkus/pull/1606#discussion_r476512634
##########
File path: .github/workflows/ci-build.yaml
##########
@@ -151,14 +150,101 @@ jobs:
df -h /
tar -xzf ../maven-repo.tgz -C ~
df -h /
- - name: Build on ${{ matrix.java }}
+ - name: cd extensions-core && mvn test
run: |
- ./mvnw -V -ntp ${BRANCH_OPTIONS} \
- clean verify
- - name: Fail if there are uncommitted changes
+ cd extensions-core
+ ../mvnw -V -ntp ${BRANCH_OPTIONS} \
+ -Dformatter.skip -Dimpsort.skip -Denforce=false -Dcamel-quarkus.update-extension-doc-page.skip \
Review comment:
It depends what you want to achieve i.e. if you check out master and you want a quick way to install everything because you are working on a side project that depends on latest camel-quarkus bits, you don't care about formattings or docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org