You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by sc...@apache.org on 2014/09/23 14:52:08 UTC

svn commit: r1626991 - in /tomcat/trunk: java/org/apache/catalina/valves/StuckThreadDetectionValve.java java/org/apache/catalina/valves/mbeans-descriptors.xml webapps/docs/changelog.xml

Author: schultz
Date: Tue Sep 23 12:52:08 2014
New Revision: 1626991

URL: http://svn.apache.org/r1626991
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57004
Add stuckThreadCount property to StuckThreadDetectionValve.

Modified:
    tomcat/trunk/java/org/apache/catalina/valves/StuckThreadDetectionValve.java
    tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
    tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/valves/StuckThreadDetectionValve.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/StuckThreadDetectionValve.java?rev=1626991&r1=1626990&r2=1626991&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/valves/StuckThreadDetectionValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/StuckThreadDetectionValve.java Tue Sep 23 12:52:08 2014
@@ -247,6 +247,10 @@ public class StuckThreadDetectionValve e
         }
     }
 
+    public int getStuckThreadCount() {
+        return stuckCount.get();
+    }
+
     public long[] getStuckThreadIds() {
         List<Long> idList = new ArrayList<>();
         for (MonitoredThread monitoredThread : activeThreads.values()) {

Modified: tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml?rev=1626991&r1=1626990&r2=1626991&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml Tue Sep 23 12:52:08 2014
@@ -517,6 +517,11 @@
                type="java.lang.String"
                writeable="false"/>
 
+    <attribute name="stuckThreadCount"
+               description="Count of the threads currently considered stuck"
+               type="int"
+               writeable="false"/>
+
     <attribute name="stuckThreadIds"
                description="IDs of the threads currently considered stuck. Each ID can then be used with the Threading MBean to retrieve data about it."
                type="long[]"

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1626991&r1=1626990&r2=1626991&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Sep 23 12:52:08 2014
@@ -148,6 +148,11 @@
         paths and are deployed as directories are correctly removed on undeploy
         when running on a case sensitive file system. (markt)
       </fix>
+      <add>
+          <bug>57004</bug>: Add <code>stuckThreadCount</code> property to
+          <code>StuckThreadDetectionValve</code>'s JMX bean. Patch provided by
+          Ji&#x159;&#xED; Pejchal. (schultz)
+      </add>
     </changelog>
   </subsection>
   <subsection name="Coyote">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org