[GitHub] [fineract] adamsaghy commented on a diff in pull request #2861: FINERACT-1785: Specified due date charges/fees cannot be applied on disbursement date

[GitBox <gi...@apache.org>]

adamsaghy commented on code in PR #2861:
URL: https://github.com/apache/fineract/pull/2861#discussion_r1064743604


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java:
##########
@@ -142,6 +143,9 @@ private Money cumulativeFeeChargesWaivedWithin(final LocalDate periodStart, fina
                     }
                 } else if (loanCharge.isDueForCollectionFromAndUpToAndIncluding(periodStart, periodEnd)) {
                     cumulative = cumulative.plus(loanCharge.getAmountWaived(currency));
+                    // Special case for Loan Charges (Due Date) added the same disbursement date
+                } else if (isFirstPeriod && periodStart.equals(loanCharge.getDueDate())) {

Review Comment:
   What about writing off a charge? (line 156)
   What about if due a charge? (line 177)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org