You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/30 12:45:19 UTC

[GitHub] [pulsar] AlvaroStream opened a new pull request, #15842: [improve][doc] numFunctionPackageReplicas explanation

AlvaroStream opened a new pull request, #15842:
URL: https://github.com/apache/pulsar/pull/15842

   Removed mention to HA in numFunctionPackage replicas that can lead to a misunderstanding where that value is related to High Availability in functions. 
   
   As it is just a way to store the function packages in Bookkeeper, and default value stores it only once in a bookie so it is dangerous in case we lose that bookie
   
   ### Motivation
   
   The explanation about HA distract me about the importance of the parameter.
   
   ### Modifications
   
   Clarify the parameter meaning.
   
   ### Verifying this change
   
   - [ X ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: ( no )
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: ( no )
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
   - [ ] `doc-not-needed` 
   
     
   - [X] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15842: [improve][doc] numFunctionPackageReplicas explanation

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15842:
URL: https://github.com/apache/pulsar/pull/15842#issuecomment-1170672832

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #15842: [improve][doc] numFunctionPackageReplicas explanation

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #15842:
URL: https://github.com/apache/pulsar/pull/15842#issuecomment-1345285263

   Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun closed pull request #15842: [improve][doc] numFunctionPackageReplicas explanation

Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #15842: [improve][doc] numFunctionPackageReplicas explanation
URL: https://github.com/apache/pulsar/pull/15842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15842: [improve][doc] numFunctionPackageReplicas explanation

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15842:
URL: https://github.com/apache/pulsar/pull/15842#discussion_r885148223


##########
site2/docs/functions-worker.md:
##########
@@ -38,7 +38,7 @@ In this mode, most of the settings are already inherited from your broker config
 
 Pay attention to the following required settings when configuring functions-worker in this mode.
 
-- `numFunctionPackageReplicas`: The number of replicas to store function packages. The default value is `1`, which is good for standalone deployment. For production deployment, to ensure high availability, set it to be larger than `2`.
+- `numFunctionPackageReplicas`: The number of replicas to store function packages. The FunctionPackage is stored in bookkeeper fully in one bookie. The default value is `1`, which is good for standalone deployment. For production deployment, set it to be larger than `2` so the function package will be stored in more than 2 bookies. In case one bookie die the others will have a copy and the function can be recovered.

Review Comment:
   @freeznet is this technically accurate?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org