[GitHub] [pinot] kishoreg commented on pull request #7904: Shade a few dependencies in `pinot-spi` and `pinot-avro-base`

[GitBox <gi...@apache.org>]

kishoreg commented on pull request #7904:
URL: https://github.com/apache/pinot/pull/7904#issuecomment-994135743


   pinot-avro-base - its ok to shade the jars in the plugin implementation though ideally we should exclude or avoid using them if possible.
   
   pinot-spi we should not be shading any library. this will cause issues down the road or we might start seeing issues at run-time. I looked the changes and its not clear why pinot-spi depends on avro.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org