You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "elonazoulay (via GitHub)" <gi...@apache.org> on 2023/04/18 18:21:58 UTC
[GitHub] [pinot] elonazoulay opened a new issue, #10637: Some math functions return different results between 0.11.0 and 0.12.1
elonazoulay opened a new issue, #10637:
URL: https://github.com/apache/pinot/issues/10637
Example: exp(2 * ln(3)) returns 8.999999999999998 in 0.11.0 and 9.000000000000002 in 0.12.1.
To repro:
```
select <column>, exp(2 * ln(3)) from <table>
```
for any table. The result is computed during parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #10637: Some math functions return different results between 0.11.0 and 0.12.1
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10637:
URL: https://github.com/apache/pinot/issues/10637#issuecomment-1522250423
I tried `Math.exp(2 * Math.log(3))` and got `9.000000000000002`, so I guess this result is expected. IMO both of them are correct, and maybe we should just use fuzzy compare when validating floating point values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #10637: Some math functions return different results between 0.11.0 and 0.12.1
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10637:
URL: https://github.com/apache/pinot/issues/10637#issuecomment-1514037992
Interesting.. We use `Math` library to calculate these values, and there should be no change between these 2 versions. Could it be caused by different jvm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] 61yao commented on issue #10637: Some math functions return different results between 0.11.0 and 0.12.1
Posted by "61yao (via GitHub)" <gi...@apache.org>.
61yao commented on issue #10637:
URL: https://github.com/apache/pinot/issues/10637#issuecomment-1526748086
>
@Jackie-Jiang Should we get https://github.com/apache/pinot/pull/10650 merged first to solve the incompatibility problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] elonazoulay commented on issue #10637: Some math functions return different results between 0.11.0 and 0.12.1
Posted by "elonazoulay (via GitHub)" <gi...@apache.org>.
elonazoulay commented on issue #10637:
URL: https://github.com/apache/pinot/issues/10637#issuecomment-1515577099
For testing, I'm running the same version of everything except the pinot docker image - same config and args.
Both the 0.12.1 and 0.11.0 image use java 11.0.16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org