You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/11/14 18:02:07 UTC
[PR] [multistage][bugfix] leaf limit refactor issue [pinot]
walterddr opened a new pull request, #12001:
URL: https://github.com/apache/pinot/pull/12001
fix a refactor issue from https://github.com/apache/pinot/pull/11937/commits/b2eb0978840a8c666c57d1f8cb04f9babc68a80b#r1393023033 in #11937
the default limit should be set before pinot query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [multistage][bugfix] leaf limit refactor issue [pinot]
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr merged PR #12001:
URL: https://github.com/apache/pinot/pull/12001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [multistage][bugfix] leaf limit refactor issue [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #12001:
URL: https://github.com/apache/pinot/pull/12001#discussion_r1393034402
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerPlanRequestUtils.java:
##########
@@ -115,10 +115,18 @@ public static OpChain compileLeafStage(OpChainExecutionContext executionContext,
* It constructs the content for {@link ServerPlanRequestContext#getPinotQuery()} and set the boundary via:
* {@link ServerPlanRequestContext#setLeafStageBoundaryNode(PlanNode)}.
*/
- private static void constructPinotQueryPlan(ServerPlanRequestContext serverContext) {
+ private static void constructPinotQueryPlan(ServerPlanRequestContext serverContext,
+ Map<String, String> requestMetadata) {
DistributedStagePlan stagePlan = serverContext.getStagePlan();
PinotQuery pinotQuery = serverContext.getPinotQuery();
pinotQuery.setExplain(false);
+ // - attach leaf node limit it not set
+ Integer leafNodeLimit = QueryOptionsUtils.getMultiStageLeafLimit(requestMetadata);
Review Comment:
```suggestion
// attach leaf node limit it not set
Integer leafNodeLimit = QueryOptionsUtils.getMultiStageLeafLimit(requestMetadata);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org