You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/21 17:24:36 UTC
[GitHub] vandanavk commented on a change in pull request #12200: [MXNET-696]
'make pylint' should run a current version of PyLint
vandanavk commented on a change in pull request #12200: [MXNET-696] 'make pylint' should run a current version of PyLint
URL: https://github.com/apache/incubator-mxnet/pull/12200#discussion_r211690499
##########
File path: ci/other/pylintrc
##########
@@ -82,7 +82,46 @@ enable=indexing-exception,old-raise-syntax
# --enable=similarities". If you want to run only the classes checker, but have
# no Warning level messages displayed, use"--disable=all --enable=classes
# --disable=W"
-disable=design,similarities,no-self-use,attribute-defined-outside-init,locally-disabled,star-args,pointless-except,bad-option-value,global-statement,fixme,suppressed-message,useless-suppression,locally-enabled,no-member,no-name-in-module,import-error,unsubscriptable-object,unbalanced-tuple-unpacking,undefined-variable,protected-access,superfluous-parens,invalid-name,no-else-return,useless-super-delegation,len-as-condition,invalid-unary-operand-type
+disable=
+ design,
+ similarities,
+ no-self-use,
+ attribute-defined-outside-init,
+ locally-disabled,
+ star-args,
+ pointless-except,
+ bad-option-value,
+ global-statement,
+ fixme,
+ suppressed-message,
+ useless-suppression,
+ locally-enabled,
+ no-member,
+ no-name-in-module,
+ import-error,
+ unsubscriptable-object,
+ unbalanced-tuple-unpacking,
+ undefined-variable,
Review comment:
Sure @cclauss. I've submitted the PR https://github.com/apache/incubator-mxnet/pull/12277. Need inputs on the use of retain though. Will add the author of retain() to the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services