You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2016/12/06 02:52:01 UTC
[Toolchain-CR] IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5370
Change subject: IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)
......................................................................
IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)
Update to Kudu git hash 60aa54e21b715a4e7a1931570c9736a2c7f211c6.
Also reverts a previous change that removed toolchain
binutils from the build PATH:
commit 2338fdd44a0439a27c6e26591c9598f859125442:
"Don't link with binutils from the toolchain"
The concern about building with the toolchain binutils was
that consumers of the toolchain binaries may need to use the
toolchain binutils, but Impala is the primary consumer and
is built with the toolchain binutils, so this doesn't seem
concerning. Further, consumers of the toolchain binaries may
also need to use other toolchain libraries and tools, so this
dependency makes sense.
This was tested in private builds which completed
successfully.
Change-Id: I506ce214010f9621b395e7a5ea80395d04a59df4
---
M buildall.sh
M init.sh
2 files changed, 4 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/70/5370/1
--
To view, visit http://gerrit.cloudera.org:8080/5370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I506ce214010f9621b395e7a5ea80395d04a59df4
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[Toolchain-CR] IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I506ce214010f9621b395e7a5ea80395d04a59df4
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has submitted this change and it was merged.
Change subject: IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)
......................................................................
IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)
Update to Kudu git hash 60aa54e21b715a4e7a1931570c9736a2c7f211c6.
Also reverts a previous change that removed toolchain
binutils from the build PATH:
commit 2338fdd44a0439a27c6e26591c9598f859125442:
"Don't link with binutils from the toolchain"
The concern about building with the toolchain binutils was
that consumers of the toolchain binaries may need to use the
toolchain binutils, but Impala is the primary consumer and
is built with the toolchain binutils, so this doesn't seem
concerning. Further, consumers of the toolchain binaries may
also need to use other toolchain libraries and tools, so this
dependency makes sense.
This was tested in private builds which completed
successfully.
Change-Id: I506ce214010f9621b395e7a5ea80395d04a59df4
---
M buildall.sh
M init.sh
2 files changed, 4 insertions(+), 6 deletions(-)
Approvals:
Matthew Jacobs: Verified
Tim Armstrong: Looks good to me, approved
Dan Hecht: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/5370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I506ce214010f9621b395e7a5ea80395d04a59df4
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Toolchain-CR] IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I506ce214010f9621b395e7a5ea80395d04a59df4
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)
......................................................................
Patch Set 1: Code-Review+1
Would be good for Tim to take a look.
--
To view, visit http://gerrit.cloudera.org:8080/5370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I506ce214010f9621b395e7a5ea80395d04a59df4
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-HasComments: No