[GitHub] [ozone] kerneltime commented on a diff in pull request #4128: HDDS-5686. Support transfer leadership

["kerneltime (via GitHub)" <gi...@apache.org>]

kerneltime commented on code in PR #4128:
URL: https://github.com/apache/ozone/pull/4128#discussion_r1083663209


##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -451,3 +451,11 @@ message ContainerBalancerConfigurationProto {
     required bool shouldRun = 18;
     optional int32 nextIterationIndex = 19;
 }
+
+message TransferLeadershipRequestProto {
+    required bool isRandom = 1;

Review Comment:
   Why do we need this flag? We can skip `isRandom`, if the nodeId is present then `isRandom = false` else `isRandom = true`. This will simplify some of the code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org