You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/20 01:30:27 UTC

[GitHub] [pulsar] xuesongxs commented on a diff in pull request #18102: [improve][broker] Add gzip compression support for /metrics endpoint

xuesongxs commented on code in PR #18102:
URL: https://github.com/apache/pulsar/pull/18102#discussion_r1000059960


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -327,6 +327,18 @@ public class ServiceConfiguration implements PulsarConfiguration {
             + "(0 to disable limiting)")
     private int maxHttpServerConnections = 2048;
 
+    @FieldContext(
+            category = CATEGORY_SERVER,
+            doc = "Enable or disable compress output metrics in prometheus"

Review Comment:
   > Since it's only Gzip, let's write it?
   
   Ok, you'd better revise it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org