[GitHub] [trafficserver] zizhong commented on a change in pull request #6686: Fixes to hostDB to avoid event and memory leaks

[GitBox <gi...@apache.org>]

zizhong commented on a change in pull request #6686:
URL: https://github.com/apache/trafficserver/pull/6686#discussion_r476276616



##########
File path: iocore/hostdb/HostDB.cc
##########
@@ -1175,12 +1174,13 @@ HostDBContinuation::dnsEvent(int event, HostEnt *e)
     timeout = nullptr;
   }
   EThread *thread = mutex->thread_holding;
-  if (event == EVENT_INTERVAL) {
+  if (event != DNS_EVENT_LOOKUP) {
+    // This was an event_interval or an event_immediate
+    // Either we timed out, or remove_trigger_pending gave up on us
     if (!action.continuation) {
       // give up on insert, it has been too long
-      // remove_trigger_pending_dns will notify and clean up all requests
-      // including this one.
-      remove_trigger_pending_dns();
+      hostDB.pending_dns_for_hash(hash.hash).remove(this);
+      hostdb_cont_free(this);

Review comment:
       hmm, should we hold the mutex before free this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org