[GitHub] [skywalking] wu-sheng commented on a change in pull request #4959: Configmap configuration

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#discussion_r451211434



##########
File path: docs/en/setup/backend/dynamic-config.md
##########
@@ -102,3 +102,16 @@ configuration:
     appId: ${SW_CONFIG_APOLLO_APP_ID:skywalking}
     period: ${SW_CONFIG_APOLLO_PERIOD:5}
 ```
+
+## Dynamic Configuration Kuberbetes Configmap Implementation
+
+[configmap](https://kubernetes.io/docs/concepts/configuration/configmap/) is also supported as DCC(Dynamic Configuration Center), to use it, just configured as follows:
+
+```yaml
+configuration:
+  selector: ${SW_CONFIGURATION:configmap}
+  configmap:
+      period: ${SW_CONFIG_CONSUL_PERIOD:60}
+      namespace: ${SW_CLUSTER_K8S_NAMESPACE:default}
+      labelSelector: ${SW_CLUSTER_K8S_LABEL:app=collector,release=skywalking}
+```

Review comment:
       Please add descriptions about how the `labelSelector` works.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org