[GitHub] [activemq-artemis] AntonRoskvist commented on pull request #3858: ARTEMIS-3557 OFF_WITH_REDISTRIBUTION - Add redistribution to old Anyc…

[GitBox <gi...@apache.org>]

AntonRoskvist commented on pull request #3858:
URL: https://github.com/apache/activemq-artemis/pull/3858#issuecomment-975611204


   @gtully  I might be wrong here, but I don't think we need to handle this with additional settings for redistribution delay for that scenario... as it is now a redistributor is added when a remote consumer is added or a local one is removed. The addition here is for a new binding where some remote consumer also exist. In that scenario we would not run into issues with unintentionally moving messages, because since the binding is just now getting created there wont be any messages to redistribute.
   
   Since we are already looking for a redistribution delay before adding the redistributor and the default is "-1" then this will only affect queues that are specifically set up to work with redistribution as well.
   
   I guess there might be a possibility for some messages to get forwarded if the queue is created by a producer and then immediately followed by a consumer... but as soon as the local consumer is added then all redistribution should stop because local consumers are favored anyway. Right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org