You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/08/13 08:18:13 UTC

[PR] Fix flaky TableMetadataReaderCompressionTest concurrency [pinot]

xiangfu0 opened a new pull request, #19243:
URL: https://github.com/apache/pinot/pull/19243

   ## Summary
   
   - Run the preferred mock compression server with two handler threads.
   - Wait for both independent preferred requests to enter their handlers.
   - Shut down the dedicated test executor during cleanup.
   
   ## Root cause
   
   The embedded `HttpServer` used its default executor, which serializes request handlers. This test sends final and retryable segment requests to the same preferred endpoint while deliberately blocking the handler. When the final request entered first, the retryable request could reach its half-deadline and be cancelled before its queued handler incremented the request counter. The test then reported `expected [2] but found [1]` even though the production deadline behavior was correct.
   
   ## How to reproduce
   
   On an unfixed checkout, repeatedly run the failing method under JDK 25 with test retries disabled:
   
   ```bash
   for attempt in {1..100}; do
     JAVA_HOME=/path/to/jdk-25 ./mvnw -q -pl pinot-controller \
       -Dtest=TableMetadataReaderCompressionTest#testFinalReplicaKeepsOverallDeadlineWhileAnotherSegmentFallsBack \
       -Dunit.test.rerun.count=0 surefire:test || break
   done
   ```
   
   The race is recorded in #19065 and in [GitHub Actions job 94326703474](https://github.com/apache/pinot/actions/runs/31661370206/job/94326703474), where the assertion failed after approximately the retryable half-deadline.
   
   ## Validation
   
   - Focused JDK 25 build with retries disabled: passed.
   - 20 independent focused Surefire executions: 20/20 passed.
   - Full `TableMetadataReaderCompressionTest`: 24 tests passed, 0 failures/errors/skips.
   - `spotless:apply`, `checkstyle:check`, `license:format`, and `license:check`: passed for `pinot-controller`.
   - `git diff --check`: passed.
   
   Closes #19065.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Fix flaky TableMetadataReaderCompressionTest concurrency [pinot]

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #19243:
URL: https://github.com/apache/pinot/pull/19243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Fix flaky TableMetadataReaderCompressionTest concurrency [pinot]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19243:
URL: https://github.com/apache/pinot/pull/19243#issuecomment-5278248568

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19243?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 57.70%. Comparing base ([`cb89c0e`](https://app.codecov.io/gh/apache/pinot/commit/cb89c0e4c566005059d3b6b97ad306f2e159ae98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d37e9a6`](https://app.codecov.io/gh/apache/pinot/commit/d37e9a60fd8923a15841979f01df4dfff358bf38?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (cb89c0e) and HEAD (d37e9a6). Click for more details.
   > 
   > <details><summary>HEAD has 14 uploads less than BASE</summary>
   >
   >| Flag | BASE (cb89c0e) | HEAD (d37e9a6) |
   >|------|------|------|
   >|unittests|2|1|
   >|java-25|4|1|
   >|temurin|4|1|
   >|lane-a|1|0|
   >|integration|2|0|
   >|integration2|2|0|
   >|lane-b|1|0|
   >|unittests2|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #19243      +/-   ##
   ============================================
   - Coverage     66.97%   57.70%   -9.28%     
   + Complexity     1417        1    -1416     
   ============================================
     Files          3453     2656     -797     
     Lines        218858   159138   -59720     
     Branches      34787    26099    -8688     
   ============================================
   - Hits         146591    91831   -54760     
   + Misses        60556    59503    -1053     
   + Partials      11711     7804    -3907     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pinot/pull/19243/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [integration](https://app.codecov.io/gh/apache/pinot/pull/19243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration2](https://app.codecov.io/gh/apache/pinot/pull/19243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [java-25](https://app.codecov.io/gh/apache/pinot/pull/19243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.70% <ø> (-9.28%)` | :arrow_down: |
   | [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [temurin](https://app.codecov.io/gh/apache/pinot/pull/19243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.70% <ø> (-9.28%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/pinot/pull/19243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.70% <ø> (-9.28%)` | :arrow_down: |
   | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.70% <ø> (-0.02%)` | :arrow_down: |
   | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/19243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19243?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org