You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/20 21:26:00 UTC

[GitHub] [spark] maryannxue opened a new pull request #24162: [SPARK-27223][SQL] Remove private methods that skip conversion when passing user schemas for constructing a DataFrame

maryannxue opened a new pull request #24162: [SPARK-27223][SQL] Remove private methods that skip conversion when passing user schemas for constructing a DataFrame
URL: https://github.com/apache/spark/pull/24162
 
 
   ## What changes were proposed in this pull request?
   
   When passing in a user schema to create a DataFrame, there might be mismatched nullability between the user schema and the the actual data. All related public interfaces now perform catalyst conversion using the user provided schema, which catches such mismatches to avoid runtime errors later on. However, there're private methods which allow this conversion to be skipped, so we need to remove these private methods which may lead to confusion and potential issues.
   
   ## How was this patch tested?
   
   Passed existing tests. No new tests were added since this PR removed the private interfaces that would potentially cause null problems and other interfaces are covered already by existing tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org