You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "rfellows (via GitHub)" <gi...@apache.org> on 2024/02/14 22:01:14 UTC

[PR] [NIFI-12790] Migrate to Angular 17 [nifi]

rfellows opened a new pull request, #8410:
URL: https://github.com/apache/nifi/pull/8410

   [NIFI-12790](https://issues.apache.org/jira/browse/NIFI-12790) Migrate to Angular 17
   
   Also migrated to use the new control-flow operators (`@if, @for, @switch, ...`)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [NIFI-12790] Migrate to Angular 17 [nifi]

Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #8410:
URL: https://github.com/apache/nifi/pull/8410#issuecomment-1945110827

   built and used locally from a user (non dev) pov.  Works great.  Overall progress on the new UI is awesome


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [NIFI-12790] Migrate to Angular 17 [nifi]

Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #8410:
URL: https://github.com/apache/nifi/pull/8410#discussion_r1491162482


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/pom.xml:
##########
@@ -27,7 +27,7 @@
     <version>2.0.0-SNAPSHOT</version>
     <packaging>war</packaging>
     <properties>
-        <node.version>v20.5.1</node.version>
+        <node.version>v21.6.1</node.version>

Review Comment:
   FYI:
   
   ```
   nifi git:(PR-8410) npm run start
   
   > nifi-web-frontend@0.0.0 start
   > ng serve
   
   Node.js version v21.6.1 detected.
   Odd numbered Node.js versions will not enter LTS status and should not be used for production. For more information, please see https://nodejs.org/en/about/previous-releases/.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [NIFI-12790] Migrate to Angular 17 [nifi]

Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #8410:
URL: https://github.com/apache/nifi/pull/8410#discussion_r1491162482


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/pom.xml:
##########
@@ -27,7 +27,7 @@
     <version>2.0.0-SNAPSHOT</version>
     <packaging>war</packaging>
     <properties>
-        <node.version>v20.5.1</node.version>
+        <node.version>v21.6.1</node.version>

Review Comment:
   FYI:
   
   ```
   nifi git:(PR-8410) npm run start
   
   > nifi-web-frontend@0.0.0 start
   > ng serve
   
   Node.js version v21.6.1 detected.
   Odd numbered Node.js versions will not enter LTS status and should not be used for production. For more information, please see https://nodejs.org/en/about/previous-releases/.
   ```
   
   We will probably want to release with the latest LTS of node and npm.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [NIFI-12790] Migrate to Angular 17 [nifi]

Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #8410:
URL: https://github.com/apache/nifi/pull/8410#discussion_r1491162482


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/pom.xml:
##########
@@ -27,7 +27,7 @@
     <version>2.0.0-SNAPSHOT</version>
     <packaging>war</packaging>
     <properties>
-        <node.version>v20.5.1</node.version>
+        <node.version>v21.6.1</node.version>

Review Comment:
   FYI:
   
   '''
   nifi git:(PR-8410) npm run start
   
   > nifi-web-frontend@0.0.0 start
   > ng serve
   
   Node.js version v21.6.1 detected.
   Odd numbered Node.js versions will not enter LTS status and should not be used for production. For more information, please see https://nodejs.org/en/about/previous-releases/.
   '''



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [NIFI-12790] Migrate to Angular 17 [nifi]

Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #8410:
URL: https://github.com/apache/nifi/pull/8410#discussion_r1491434252


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/pom.xml:
##########
@@ -27,7 +27,7 @@
     <version>2.0.0-SNAPSHOT</version>
     <packaging>war</packaging>
     <properties>
-        <node.version>v20.5.1</node.version>
+        <node.version>v21.6.1</node.version>

Review Comment:
   https://issues.apache.org/jira/browse/NIFI-12802



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [NIFI-12790] Migrate to Angular 17 [nifi]

Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman merged PR #8410:
URL: https://github.com/apache/nifi/pull/8410


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org