You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Richard S. Hall (JIRA)" <ji...@apache.org> on 2010/09/20 17:42:32 UTC

[jira] Created: (FELIX-2604) Remote Shell not correctly catching exceptions in TerminalPrintStream

Remote Shell not correctly catching exceptions in TerminalPrintStream
---------------------------------------------------------------------

                 Key: FELIX-2604
                 URL: https://issues.apache.org/jira/browse/FELIX-2604
             Project: Felix
          Issue Type: Bug
          Components: Remote Shell
    Affects Versions: shell.remote-1.1.0
            Reporter: Richard S. Hall
            Assignee: Richard S. Hall
            Priority: Minor
             Fix For: shell.remote-1.1.2


In TerminalPrintStream.flush(), the internal call to out.flush() is bracket by a try block catching an IOException, but it appears that out gets set to null at point an the method ends up throwing an NPE. We should probably catch Exception, like the other methods in TerminalPrintStream to avoid this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (FELIX-2604) Remote Shell not correctly catching exceptions in TerminalPrintStream

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall closed FELIX-2604.
----------------------------------

    Resolution: Fixed

I've committed a patch that works for now.

> Remote Shell not correctly catching exceptions in TerminalPrintStream
> ---------------------------------------------------------------------
>
>                 Key: FELIX-2604
>                 URL: https://issues.apache.org/jira/browse/FELIX-2604
>             Project: Felix
>          Issue Type: Bug
>          Components: Remote Shell
>    Affects Versions: shell.remote-1.1.0
>            Reporter: Richard S. Hall
>            Assignee: Richard S. Hall
>            Priority: Minor
>             Fix For: shell.remote-1.1.2
>
>
> In TerminalPrintStream.flush(), the internal call to out.flush() is bracket by a try block catching an IOException, but it appears that out gets set to null at point an the method ends up throwing an NPE. We should probably catch Exception, like the other methods in TerminalPrintStream to avoid this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.