You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2016/01/20 17:50:32 UTC
Review Request 42558: Ldap: unnecessary logging during sync
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42558/
-----------------------------------------------------------
Review request for Ambari, Robert Levas and Sebastian Toader.
Bugs: AMBARI-14744
https://issues.apache.org/jira/browse/AMBARI-14744
Repository: ambari
Description
-------
In case of returnObjFlag is not set in SearchControls object, it sets a default value. Then its logging something with 'INFO' logging level. That line is called on every ldap query
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java 3d2685e
Diff: https://reviews.apache.org/r/42558/diff/
Testing
-------
Manually tested
Thanks,
Oliver Szabo
Re: Review Request 42558: Ldap: unnecessary logging during sync
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42558/#review115450
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Jan. 20, 2016, 11:50 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42558/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 11:50 a.m.)
>
>
> Review request for Ambari, Robert Levas and Sebastian Toader.
>
>
> Bugs: AMBARI-14744
> https://issues.apache.org/jira/browse/AMBARI-14744
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of returnObjFlag is not set in SearchControls object, it sets a default value. Then its logging something with 'INFO' logging level. That line is called on every ldap query
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java 3d2685e
>
> Diff: https://reviews.apache.org/r/42558/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 42558: Ldap: unnecessary logging during sync
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42558/#review115574
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Jan. 20, 2016, 5:50 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42558/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 5:50 p.m.)
>
>
> Review request for Ambari, Robert Levas and Sebastian Toader.
>
>
> Bugs: AMBARI-14744
> https://issues.apache.org/jira/browse/AMBARI-14744
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of returnObjFlag is not set in SearchControls object, it sets a default value. Then its logging something with 'INFO' logging level. That line is called on every ldap query
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java 3d2685e
>
> Diff: https://reviews.apache.org/r/42558/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Oliver Szabo
>
>