You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/06 02:36:37 UTC

[GitHub] [incubator-dolphinscheduler] khadgarmage commented on a change in pull request #1707: Fix sonarcloud analysis on merge PR

khadgarmage commented on a change in pull request #1707: Fix sonarcloud analysis on merge PR
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1707#discussion_r363039837
 
 

 ##########
 File path: .github/workflows/ci_ut.yml
 ##########
 @@ -49,18 +49,6 @@ jobs:
           export MAVEN_OPTS='-Dmaven.repo.local=.m2/repository -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:-UseGCOverheadLimit -Xmx3g'
           mvn test -Dmaven.test.skip=false cobertura:cobertura
           CODECOV_TOKEN="09c2663f-b091-4258-8a47-c981827eb29a" bash <(curl -s https://codecov.io/bash)
-      - name: Run SonarCloud analysis
 
 Review comment:
   Why not put the job in this work flow? Trigger can be push and pull_request?
   ----------
   我看基本上没啥变化，都放到这里push和pull_request就可以了吧？

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services