You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/17 14:58:29 UTC
[GitHub] [druid] suneet-s opened a new pull request #10043: Add support for REGEXP_REPLACE
suneet-s opened a new pull request #10043:
URL: https://github.com/apache/druid/pull/10043
### Description
This function is similar to `regexp_replace` functions offered by other databases like
postgres and oracle.
This function unlocks a few use-cases
* Name rearrangement
If a column stores the name as first last, but you would prefer the report
to be displayed as last, first
`SELECT REGEXP_REPLACE('John Doe','(.*) (.*)','$2, $1');`
* String removal
If you'd prefer to replace a string that matches a pattern - for example
email addresses that might be in a text column, you can replace the pattern
with generic text so that queries don't accidentally leak data.
`SELECT DISTINCT REGEXP_REPLACE(diffUrl, 'diff=\d*', 'diff=****'`) from wikipedia`
This PR has:
- [ ] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-748615159
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-756624168
This issue is no longer marked as stale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-756624168
This issue is no longer marked as stale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-711078471
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-756624149
> one more time please stalebot 🙏
two more times? 🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-645427929
Marked as WIP since it has insufficient tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-712256641
one more time please stalebot 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-756624149
> one more time please stalebot 🙏
two more times? 🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-674539182
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] hosswald commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
hosswald commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-1022116353
Just want to say that I'm really looking forward to this being eventually merged and thank @suneet-s for implementing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-674920546
not stale... new PR coming this month 🤞
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-674920580
This issue is no longer marked as stale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on pull request #10043: Add support for REGEXP_REPLACE
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10043:
URL: https://github.com/apache/druid/pull/10043#issuecomment-712256678
This issue is no longer marked as stale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org