You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/15 06:58:18 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #39578: [SPARK-42071][CORE] Register `scala.math.Ordering$Reverse` to KyroSerializer
dongjoon-hyun opened a new pull request, #39578:
URL: https://github.com/apache/spark/pull/39578
### What changes were proposed in this pull request?
This PR aims to register `scala.math.Ordering$Reverse` to KyroSerializer.
### Why are the changes needed?
Scala 2.12.12 added a new class 'Reverse' via https://github.com/scala/scala/pull/8965
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs with newly added test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39578: [SPARK-42071][CORE] Register `scala.math.Ordering$Reverse` to KyroSerializer
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #39578:
URL: https://github.com/apache/spark/pull/39578#issuecomment-1383097130
Merged to master/3.3/3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39578: [SPARK-42071][CORE] Register `scala.math.Ordering$Reverse` to KyroSerializer
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #39578:
URL: https://github.com/apache/spark/pull/39578#issuecomment-1383073125
Could you review this, please, @mridulm ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a diff in pull request #39578: [SPARK-42071][CORE] Register `scala.math.Ordering$Reverse` to KyroSerializer
Posted by GitBox <gi...@apache.org>.
mridulm commented on code in PR #39578:
URL: https://github.com/apache/spark/pull/39578#discussion_r1070529359
##########
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala:
##########
@@ -219,6 +219,7 @@ class KryoSerializer(conf: SparkConf)
kryo.register(Nil.getClass)
kryo.register(Utils.classForName("scala.collection.immutable.$colon$colon"))
kryo.register(Utils.classForName("scala.collection.immutable.Map$EmptyMap$"))
+ kryo.register(Utils.classForName("scala.math.Ordering$Reverse"))
Review Comment:
Ah, I can see this in intellij (decompiled) - interesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39578: [SPARK-42071][CORE] Register `scala.math.Ordering$Reverse` to KyroSerializer
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #39578:
URL: https://github.com/apache/spark/pull/39578#issuecomment-1383087868
Thank you, @mridulm !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a diff in pull request #39578: [SPARK-42071][CORE] Register `scala.math.Ordering$Reverse` to KyroSerializer
Posted by GitBox <gi...@apache.org>.
mridulm commented on code in PR #39578:
URL: https://github.com/apache/spark/pull/39578#discussion_r1070528611
##########
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala:
##########
@@ -219,6 +219,7 @@ class KryoSerializer(conf: SparkConf)
kryo.register(Nil.getClass)
kryo.register(Utils.classForName("scala.collection.immutable.$colon$colon"))
kryo.register(Utils.classForName("scala.collection.immutable.Map$EmptyMap$"))
+ kryo.register(Utils.classForName("scala.math.Ordering$Reverse"))
Review Comment:
Where is this coming from ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #39578: [SPARK-42071][CORE] Register `scala.math.Ordering$Reverse` to KyroSerializer
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #39578: [SPARK-42071][CORE] Register `scala.math.Ordering$Reverse` to KyroSerializer
URL: https://github.com/apache/spark/pull/39578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a diff in pull request #39578: [SPARK-42071][CORE] Register `scala.math.Ordering$Reverse` to KyroSerializer
Posted by GitBox <gi...@apache.org>.
mridulm commented on code in PR #39578:
URL: https://github.com/apache/spark/pull/39578#discussion_r1070529359
##########
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala:
##########
@@ -219,6 +219,7 @@ class KryoSerializer(conf: SparkConf)
kryo.register(Nil.getClass)
kryo.register(Utils.classForName("scala.collection.immutable.$colon$colon"))
kryo.register(Utils.classForName("scala.collection.immutable.Map$EmptyMap$"))
+ kryo.register(Utils.classForName("scala.math.Ordering$Reverse"))
Review Comment:
Ah, I can see this in the jar - not in the decompiled classes - interesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org