You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2015/04/07 18:31:52 UTC
[GitHub] storm pull request: Update BYLAWS.md for clarification of code-cha...
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/511
Update BYLAWS.md for clarification of code-change policy
The code change policy contains phrasing that sounds contradictory to me.
The sentence: "The code can be committed after the first +1" has been removed.
NOTE: This pull request should not be merged until a successful VOTE for adoption has taken place.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/511.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #511
----
commit 3b76dfec04c9bd41d914ff178219e8919ec46e0b
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2015-04-07T16:07:28Z
Update approval of code changes to clarify.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Update BYLAWS.md for clarification of code-cha...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/511#issuecomment-95327851
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Update BYLAWS.md for clarification of code-cha...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Update BYLAWS.md for clarification of code-cha...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/511#issuecomment-167629053
@knusbaum, would you put this to a VOTE so we can make a decision on merging it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Update BYLAWS.md for clarification of code-cha...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/511#issuecomment-90938279
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---