You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/20 10:05:22 UTC
[GitHub] [beam] mosche opened a new pull request, #17407: [BEAM-14335] Spotless Spark sources
mosche opened a new pull request, #17407:
URL: https://github.com/apache/beam/pull/17407
Add spotless config for the shared Spark sources similar to Flink.
All other changes are just formatting ...
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on pull request #17407: [BEAM-14335] Spotless Spark sources
Posted by GitBox <gi...@apache.org>.
mosche commented on PR #17407:
URL: https://github.com/apache/beam/pull/17407#issuecomment-1104099112
Just fixed it the way it got fixed for flink. Same problem there before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17407: [BEAM-14335] Spotless Spark sources
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17407:
URL: https://github.com/apache/beam/pull/17407#issuecomment-1103992757
@mosche IINM, I see quite significant amount of code style changes. Could you split this PR into two commits - one with code style changes and another one with actual changes to review? It should help to do a review more efficiently and have a clean code changes history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev merged pull request #17407: [BEAM-14335] Spotless Spark sources
Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged PR #17407:
URL: https://github.com/apache/beam/pull/17407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on pull request #17407: [BEAM-14335] Spotless Spark sources
Posted by GitBox <gi...@apache.org>.
mosche commented on PR #17407:
URL: https://github.com/apache/beam/pull/17407#issuecomment-1103763186
R: @echauchot
R: @aromanenko-dev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on pull request #17407: [BEAM-14335] Spotless Spark sources
Posted by GitBox <gi...@apache.org>.
mosche commented on PR #17407:
URL: https://github.com/apache/beam/pull/17407#issuecomment-1104025703
I can't @aromanenko-dev , if i commit the spotless gradle config without applying it checks will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #17407: [BEAM-14335] Spotless Spark sources
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17407:
URL: https://github.com/apache/beam/pull/17407#issuecomment-1104029964
Hmm, how it worked before? It didn't check old code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on pull request #17407: [BEAM-14335] Spotless Spark sources
Posted by GitBox <gi...@apache.org>.
mosche commented on PR #17407:
URL: https://github.com/apache/beam/pull/17407#issuecomment-1104092545
It didn't do any formatting checks previously... Spotless wasn't enabled for the shared sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org