You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2017/02/21 17:39:50 UTC

[GitHub] kafka pull request #2580: MINOR: Move ProtoUtils methods to ApiKeys

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/2580

    MINOR: Move ProtoUtils methods to ApiKeys

    Also move `requireTimestamp` to `minVersion` logic from `Fetcher` to
    `ListOffsetRequest.Builder.forConsumer()`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka move-proto-utils-to-api-keys

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2580
    
----
commit a8078e43e9a2c48198c6eeb2981ebbdc44fe7ec9
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-02-21T16:52:43Z

    MINOR: Move ProtoUtils methods to ApiKeys

commit 4f4ed91bd914e8e25ecb314c07d5907000ba3439
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-02-21T17:38:07Z

    Take a `requireTimestamp` boolean instead of `minVersion` in `ListOffsetRequest.Builder.forConsumer`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #2580: MINOR: Move ProtoUtils methods to ApiKeys

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/2580


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---