[GitHub] [systemds] mboehm7 commented on pull request #1165: [SYSTEMDS-2801] Rewrite rule to remove (par)for-loops over empty sequences.

[GitBox <gi...@apache.org>]

mboehm7 commented on pull request #1165:
URL: https://github.com/apache/systemds/pull/1165#issuecomment-766162227


   LGTM - welcome to SystemDS @pdamme and thanks for the patch. During the merge, I fixed a few related for/parfor issues (for correctly handling special values like NaN/Inf/-Inf), fixed the issue of my previous commit, simplified and generalized the rewrite a bit, and added the tests you already discussed. The test simply checks that after this rewrite, we do common subexpression elimination of ops before and after the loop.
   ```
   
   print(sum(X));
   for(i in seq(NaN,1))
     print("Iteration "+i)
   print(sum(X))
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org