[GitHub] gengliangwang commented on a change in pull request #23914: [SPARK-27009][TEST] Add Standard Deviation to benchmark results

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #23914: [SPARK-27009][TEST] Add Standard Deviation to benchmark results
URL: https://github.com/apache/spark/pull/23914#discussion_r261129277
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/benchmark/Benchmark.scala
 ##########
 @@ -111,16 +111,17 @@ private[spark] class Benchmark(
     // The results are going to be processor specific so it is useful to include that.
     out.println(Benchmark.getJVMOSInfo())
     out.println(Benchmark.getProcessorName())
-    out.printf("%-40s %16s %12s %13s %10s\n", name + ":", "Best/Avg Time(ms)", "Rate(M/s)",
-      "Per Row(ns)", "Relative")
-    out.println("-" * 96)
+    out.printf("%-40s %16s %12s %13s %10s %13s\n", name + ":", "Best/Avg Time(ms)", "Rate(M/s)",
+      "Per Row(ns)", "Relative", "Stdev (ms)")
 
 Review comment:
   @dongjoon-hyun I thought about this. But then the readability of the numbers might be worse.
   How about make each of them a single column? E.g. 
   `Best Time(ms)    Avg Time(ms)    BestStdev Time(ms) `
   I don't have a strong preference here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org