You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "garymm (via GitHub)" <gi...@apache.org> on 2023/04/08 21:33:31 UTC

[GitHub] [thrift] garymm opened a new pull request, #2778: THRIFT-5698: remove use of deprecated std::iterator

garymm opened a new pull request, #2778:
URL: https://github.com/apache/thrift/pull/2778

   C++17 deprecated std::iterator.
   
   See
   https://www.fluentcpp.com/2018/05/08/std-iterator-deprecated/
   
   Prior to this change, compiling while targeting C++17 or higher results
   in warnings.
   
   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [ ] Did you squash your changes to a single commit?  (not required, but preferred)
   - [ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] THRIFT-5698: remove use of deprecated std::iterator [thrift]

Posted by "garymm (via GitHub)" <gi...@apache.org>.
garymm commented on PR #2778:
URL: https://github.com/apache/thrift/pull/2778#issuecomment-1861961579

   This is still valid, but closing since it's been ignored for so long.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] THRIFT-5698: remove use of deprecated std::iterator [thrift]

Posted by "garymm (via GitHub)" <gi...@apache.org>.
garymm closed pull request #2778: THRIFT-5698: remove use of deprecated std::iterator
URL: https://github.com/apache/thrift/pull/2778


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org