You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/12/02 23:20:38 UTC
[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7230: Add Traffic Router unit tests too Codecov
ericholguin opened a new pull request, #7230:
URL: https://github.com/apache/trafficcontrol/pull/7230
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
Adds the jacoco plugin in order to enable code coverage reports
Codecov can leverage these report results to determine test coverage
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Router (pom.xml)
- GitHub Actions
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Verify the TR Test GHA runs successfully
Verify Codecov report is successfully uploaded
## PR submission checklist
- [ ] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7230: Add Traffic Router unit tests to Codecov
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on code in PR #7230:
URL: https://github.com/apache/trafficcontrol/pull/7230#discussion_r1038622457
##########
traffic_router/pom.xml:
##########
@@ -71,6 +71,19 @@
<showDeprecation>true</showDeprecation>
</configuration>
</plugin>
+ <plugin>
Review Comment:
Needs `<scope>test</scope>` so jacoco doesn't get included in RPMs
##########
traffic_router/core/pom.xml:
##########
@@ -242,6 +255,12 @@
<version>${project.parent.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.traffic_control.traffic_router</groupId>
+ <artifactId>traffic_router_connector</artifactId>
+ <version>${project.parent.version}</version>
+ </dependency>
Review Comment:
The TR connector is not a dependency of the TR core
##########
traffic_router/core/pom.xml:
##########
@@ -226,6 +226,19 @@
<attachClasses>true</attachClasses>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.jacoco</groupId>
Review Comment:
Needs `<scope>test</scope>` so jacoco doesn't get included in RPMs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #7230: Add Traffic Router unit tests to Codecov
Posted by GitBox <gi...@apache.org>.
zrhoffman merged PR #7230:
URL: https://github.com/apache/trafficcontrol/pull/7230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7230: Add Traffic Router unit tests to Codecov
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7230:
URL: https://github.com/apache/trafficcontrol/pull/7230#issuecomment-1335958006
# [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7230?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7230](https://codecov.io/gh/apache/trafficcontrol/pull/7230?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (40aa219) into [master](https://codecov.io/gh/apache/trafficcontrol/commit/2ab9ffd39f3943548438a7249b843acc92b335d6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ab9ffd) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #7230 +/- ##
==========================================
Coverage 28.35% 28.36%
- Complexity 0 98 +98
==========================================
Files 589 617 +28
Lines 68241 69195 +954
Branches 0 90 +90
==========================================
+ Hits 19347 19624 +277
- Misses 47117 47760 +643
- Partials 1777 1811 +34
```
| Flag | Coverage Δ | |
|---|---|---|
| traffic_router_unit | `29.03% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/trafficcontrol/pull/7230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/traffic\_control/traffic\_router/secure/Pkcs1.java](https://codecov.io/gh/apache/trafficcontrol/pull/7230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19yb3V0ZXIvc2hhcmVkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90cmFmZmljX2NvbnRyb2wvdHJhZmZpY19yb3V0ZXIvc2VjdXJlL1BrY3MxLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...control/traffic\_router/shared/ZoneTestRecords.java](https://codecov.io/gh/apache/trafficcontrol/pull/7230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19yb3V0ZXIvc2hhcmVkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90cmFmZmljX2NvbnRyb2wvdHJhZmZpY19yb3V0ZXIvc2hhcmVkL1pvbmVUZXN0UmVjb3Jkcy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ontrol/traffic\_router/geolocation/Geolocation.java](https://codecov.io/gh/apache/trafficcontrol/pull/7230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19yb3V0ZXIvZ2VvbG9jYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RyYWZmaWNfY29udHJvbC90cmFmZmljX3JvdXRlci9nZW9sb2NhdGlvbi9HZW9sb2NhdGlvbi5qYXZh) | `30.18% <0.00%> (ø)` | |
| [...e/traffic\_control/traffic\_router/secure/Pkcs8.java](https://codecov.io/gh/apache/trafficcontrol/pull/7230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19yb3V0ZXIvc2hhcmVkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90cmFmZmljX2NvbnRyb2wvdHJhZmZpY19yb3V0ZXIvc2VjdXJlL1BrY3M4LmphdmE=) | `66.66% <0.00%> (ø)` | |
| [...rol/traffic\_router/protocol/RouterNioEndpoint.java](https://codecov.io/gh/apache/trafficcontrol/pull/7230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19yb3V0ZXIvY29ubmVjdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90cmFmZmljX2NvbnRyb2wvdHJhZmZpY19yb3V0ZXIvcHJvdG9jb2wvUm91dGVyTmlvRW5kcG9pbnQuamF2YQ==) | `1.66% <0.00%> (ø)` | |
| [...ol/traffic\_router/protocol/LanguidNioProtocol.java](https://codecov.io/gh/apache/trafficcontrol/pull/7230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19yb3V0ZXIvY29ubmVjdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90cmFmZmljX2NvbnRyb2wvdHJhZmZpY19yb3V0ZXIvcHJvdG9jb2wvTGFuZ3VpZE5pb1Byb3RvY29sLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...\_control/traffic\_router/secure/BindPrivateKey.java](https://codecov.io/gh/apache/trafficcontrol/pull/7230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19yb3V0ZXIvc2hhcmVkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90cmFmZmljX2NvbnRyb2wvdHJhZmZpY19yb3V0ZXIvc2VjdXJlL0JpbmRQcml2YXRlS2V5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ntrol/traffic\_router/protocol/LanguidProtocol.java](https://codecov.io/gh/apache/trafficcontrol/pull/7230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19yb3V0ZXIvY29ubmVjdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90cmFmZmljX2NvbnRyb2wvdHJhZmZpY19yb3V0ZXIvcHJvdG9jb2wvTGFuZ3VpZFByb3RvY29sLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...fic\_control/traffic\_router/shared/SigningData.java](https://codecov.io/gh/apache/trafficcontrol/pull/7230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19yb3V0ZXIvc2hhcmVkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90cmFmZmljX2NvbnRyb2wvdHJhZmZpY19yb3V0ZXIvc2hhcmVkL1NpZ25pbmdEYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...control/traffic\_router/protocol/RouterSslUtil.java](https://codecov.io/gh/apache/trafficcontrol/pull/7230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19yb3V0ZXIvY29ubmVjdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90cmFmZmljX2NvbnRyb2wvdHJhZmZpY19yb3V0ZXIvcHJvdG9jb2wvUm91dGVyU3NsVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/trafficcontrol/pull/7230/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org