[GitHub] [lucene-solr] iverase commented on a change in pull request #2245: LUCENE-9322: Move old field infos format to backwards-codecs.

[GitBox <gi...@apache.org>]

iverase commented on a change in pull request #2245:
URL: https://github.com/apache/lucene-solr/pull/2245#discussion_r564450316



##########
File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene60/Lucene60FieldInfosFormat.java
##########
@@ -311,6 +312,11 @@ private static IndexOptions getIndexOptions(IndexInput input, byte b) throws IOE
     }
   }
 
+  /**
+   * Note: although this format is only used on older versions, we need to keep the write logic

Review comment:
       In theory it is possible to try to add a new vector field to one segment create with this format, I guess it would break?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org