You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/15 21:23:07 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #9549: Bump
@superset-ui/legacy-plugin-chart-table to 0.12.14
ktmud opened a new pull request #9549: Bump @superset-ui/legacy-plugin-chart-table to 0.12.14
URL: https://github.com/apache/incubator-superset/pull/9549
### CATEGORY
- [x] Bug Fix
### SUMMARY
https://github.com/apache/incubator-superset/issues/9499 introduced a new feature to the table chart, but to plugin package was not updated.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
Make sure hide cell bar option can work on table chart.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue: https://github.com/apache/incubator-superset/issues/9499
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@rusackas @kristw @john-bodley
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9549:
Bump @superset-ui/legacy-plugin-chart-table to 0.12.14
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9549: Bump @superset-ui/legacy-plugin-chart-table to 0.12.14
URL: https://github.com/apache/incubator-superset/pull/9549#issuecomment-614290266
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=h1) Report
> Merging [#9549](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/403d5d6542d646c3fafd53932256cd95cb8e4255&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9549 +/- ##
==========================================
- Coverage 65.45% 65.43% -0.03%
==========================================
Files 571 571
Lines 29847 29847
Branches 3040 3040
==========================================
- Hits 19535 19529 -6
- Misses 10128 10134 +6
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.77% <ø> (ø)` | |
| #mysql | `70.08% <ø> (ø)` | |
| #postgres | `?` | |
| #python | `70.14% <ø> (-0.04%)` | :arrow_down: |
| #sqlite | `69.92% <ø> (ø)` | |
| #unittest | `65.43% <ø> (-0.03%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=footer). Last update [403d5d6...8472a70](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9549:
Bump @superset-ui/legacy-plugin-chart-table to 0.12.14
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9549: Bump @superset-ui/legacy-plugin-chart-table to 0.12.14
URL: https://github.com/apache/incubator-superset/pull/9549#issuecomment-614290266
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=h1) Report
> Merging [#9549](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/403d5d6542d646c3fafd53932256cd95cb8e4255&el=desc) will **increase** coverage by `4.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9549 +/- ##
==========================================
+ Coverage 65.45% 70.05% +4.60%
==========================================
Files 571 182 -389
Lines 29847 17477 -12370
Branches 3040 0 -3040
==========================================
- Hits 19535 12244 -7291
+ Misses 10128 5233 -4895
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (ø)` | |
| #python | `70.05% <ø> (-0.13%)` | :arrow_down: |
| #sqlite | `?` | |
| #unittest | `70.05% <ø> (+4.60%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.75% <0.00%> (-1.17%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.23%)` | :arrow_down: |
| [...perset-frontend/src/utils/DebouncedMessageQueue.js](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL0RlYm91bmNlZE1lc3NhZ2VRdWV1ZS5qcw==) | | |
| [.../src/dashboard/components/menu/PopoverDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvUG9wb3ZlckRyb3Bkb3duLmpzeA==) | | |
| [...t-frontend/src/dashboard/components/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlQWRkZXIuanN4) | | |
| [...components/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU3FsVGFiQ29udGVudC5qc3g=) | | |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=footer). Last update [403d5d6...8472a70](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #9549: Bump
@superset-ui/legacy-plugin-chart-table to 0.12.14
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9549: Bump @superset-ui/legacy-plugin-chart-table to 0.12.14
URL: https://github.com/apache/incubator-superset/pull/9549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9549: Bump
@superset-ui/legacy-plugin-chart-table to 0.12.14
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9549: Bump @superset-ui/legacy-plugin-chart-table to 0.12.14
URL: https://github.com/apache/incubator-superset/pull/9549#issuecomment-614290266
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=h1) Report
> Merging [#9549](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/403d5d6542d646c3fafd53932256cd95cb8e4255&el=desc) will **increase** coverage by `4.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9549 +/- ##
==========================================
+ Coverage 65.45% 70.05% +4.60%
==========================================
Files 571 182 -389
Lines 29847 17477 -12370
Branches 3040 0 -3040
==========================================
- Hits 19535 12244 -7291
+ Misses 10128 5233 -4895
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `70.05% <ø> (ø)` | |
| #python | `70.05% <ø> (-0.13%)` | :arrow_down: |
| #sqlite | `?` | |
| #unittest | `70.05% <ø> (+4.60%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.75% <0.00%> (-1.17%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.23%)` | :arrow_down: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | | |
| [superset-frontend/src/explore/AdhocMetric.js](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQWRob2NNZXRyaWMuanM=) | | |
| [...et-frontend/src/components/RefreshChartOverlay.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaENoYXJ0T3ZlcmxheS5qc3g=) | | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | | |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/9549/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=footer). Last update [403d5d6...8472a70](https://codecov.io/gh/apache/incubator-superset/pull/9549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org