[jira] [Commented] (GOSSIP-82) Messages need to be refactored

["Edward Capriolo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GOSSIP-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977043#comment-15977043 ] 

Edward Capriolo commented on GOSSIP-82:
---------------------------------------

Trackable should be built into to probably every message

Trackable implies that a reply is expected and there is only one case that we do this. The ActiveMessage will reply with a fault if the cluster is not the same. Generally I do not want each message to have a reply it is overhead that does not provide anything that I can think of. (for the message types we have now)

> Messages need to be refactored
> ------------------------------
>
>                 Key: GOSSIP-82
>                 URL: https://issues.apache.org/jira/browse/GOSSIP-82
>             Project: Gossip
>          Issue Type: Improvement
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>
> The message classes (things that get send across the wire) are confusing for the following reasons:
> * Abstract classes where a simple tagging interface would suffice (look at the classes that extend other classes but do not add any fields or methods)
> * Trackable should be built into to probably every message
> * The UDP implementations are probably superfluous.
> * It is difficult to know what all the message types are, which are abstract or concrete, etc. It would be nice if we had a class that tracked all the default message types in a static list/array.
> I'd like to see a flatter inheritance structure and more use of interfaces vs abstract classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)