[GitHub] wohali commented on a change in pull request #1160: Add support for Bcrypt password hashing

[GitBox <gi...@apache.org>]

wohali commented on a change in pull request #1160: Add support for Bcrypt password hashing
URL: https://github.com/apache/couchdb/pull/1160#discussion_r167745871
 
 

 ##########
 File path: src/couch/src/couch_users_db.erl
 ##########
 @@ -75,7 +76,7 @@ save_doc(#doc{body={Body}} = Doc) ->
         Body3 = proplists:delete(?PASSWORD, Body2),
         Doc#doc{body={Body3}};
     {ClearPassword, "pbkdf2"} ->
-        Iterations = list_to_integer(config:get("couch_httpd_auth", "iterations", "1000")),
+        Iterations = list_to_integer(config:get("couch_httpd_auth", "iterations", "10000")),
 
 Review comment:
   You can't change the default here without good reason; there are likely reasons it is set to 1000 not 10000. It is also an unrelated change to the proposed addition of `bcrypt`, isn't it? This is the `pbkdf2` section.
   
   Any change to a `config:get` block must be matched with parallel changes to `rel/overlay/etc/default.ini`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services