[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6226: feat: min/max agg for bool

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6226:
URL: https://github.com/apache/arrow-datafusion/pull/6226#discussion_r1185122825


##########
datafusion/physical-expr/src/aggregate/min_max.rs:
##########
@@ -1429,4 +1441,38 @@ mod tests {
             ScalarValue::Time64Nanosecond(Some(5))
         )
     }
+
+    #[test]
+    fn max_bool() -> Result<()> {

Review Comment:
   I think it would be good to test NULL handling as well:
   1. If the inputs is all nulls
   3. The input contains nulls and non nulls
   
   Perhaps we could do so with a sqllogictest: https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sqllogictests/test_files/aggregate.slt



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org