You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "smengcl (via GitHub)" <gi...@apache.org> on 2026/08/13 05:51:00 UTC
[PR] HDDS-11128. Increase timeout for decommission-triggered replica-count waits in TestReconAndAdminContainerCLI [ozone]
smengcl opened a new pull request, #11010:
URL: https://github.com/apache/ozone/pull/11010
Generated-by: Claude Code (Opus 4.8)
## What changes were proposed in this pull request?
`TestReconAndAdminContainerCLI#testNodesInDecommissionOrMaintenance` (decommission parameterization) intermittently times out at `OzoneTestHelper.waitForReplicaCount` while waiting for a decommission-triggered replica copy (3 to 4 for the first node, 4 to 5 for the second) to be reflected in SCM.
The shared `waitForReplicaCount` helper used a fixed 30s budget for all of its callers. HDDS-10582 only reduced the poll interval (1000ms to 200ms) and kept the 30s total, so under a loaded CI runner the replica copy is not always observed within the budget and the test flakes.
This adds a 4-arg `waitForReplicaCount` overload that accepts a timeout, leaving the existing 3-arg method delegating with the same 30s default (no behavior change for the other callers). The decommission/maintenance replica-copy waits in `TestReconAndAdminContainerCLI` now use a 120s budget, matching the larger timeouts already adopted elsewhere for this class of replication waits. The test stays tagged `@Flaky("HDDS-11128")` because a larger timeout cannot prove non-flakiness.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11128
## How was this patch tested?
Existing test, no new coverage added (timeout-only change to a flaky integration test).
- `mvn -pl :ozone-integration-test test-compile` and `mvn -pl :ozone-integration-test-recon test-compile`: both compile.
- `checkstyle.sh` on both changed modules: no violations.
This is a timeout increase, so a single green run cannot prove the flake is gone; the change only widens the window in which the decommission-triggered replica copy must be observed, and leaves the `@Flaky` tag in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11128. Isolate maintenance and decommission test invocations [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11010:
URL: https://github.com/apache/ozone/pull/11010#issuecomment-5627241031
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11128. Increase timeout for decommission-triggered replica-count waits in TestReconAndAdminContainerCLI [ozone]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #11010:
URL: https://github.com/apache/ozone/pull/11010#discussion_r3772764935
##########
hadoop-ozone/integration-test-recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconAndAdminContainerCLI.java:
##########
@@ -114,6 +114,12 @@ class TestReconAndAdminContainerCLI {
* are still drifting past each other (HDDS-15223).
*/
private static final int RM_RECON_COMPARE_STABLE_POLLS = 2;
+ /**
+ * Max wait for a decommission/maintenance triggered replica copy to be reflected in SCM. The
+ * default {@link OzoneTestHelper#waitForReplicaCount} budget (30s) is not always enough on a
+ * loaded CI runner, which is the recurring flake tracked in HDDS-11128 (see also HDDS-10582).
Review Comment:
The Javadoc link `{@link OzoneTestHelper#waitForReplicaCount}` is now ambiguous because `OzoneTestHelper` has multiple `waitForReplicaCount` overloads. This can cause Javadoc resolution warnings/errors under doclint. Use a signature-qualified link to the 3-arg default-timeout overload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11128. Isolate maintenance and decommission test invocations [ozone]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl merged PR #11010:
URL: https://github.com/apache/ozone/pull/11010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11128. Isolate maintenance and decommission test invocations [ozone]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #11010:
URL: https://github.com/apache/ozone/pull/11010#issuecomment-6106723926
Thanks @Russole for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org