You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/02/24 22:17:54 UTC
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request
#596: HDDS-3066. SCM crash during loading containers to DB.
xiaoyuyao commented on a change in pull request #596: HDDS-3066. SCM crash during loading containers to DB.
URL: https://github.com/apache/hadoop-ozone/pull/596#discussion_r383548033
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
##########
@@ -117,9 +126,17 @@ private void loadExistingContainers() throws IOException {
ContainerInfoProto.PARSER.parseFrom(entry.getValue()));
Preconditions.checkNotNull(container);
containerStateManager.loadContainer(container);
- if (container.getState() == LifeCycleState.OPEN) {
- pipelineManager.addContainerToPipeline(container.getPipelineID(),
- ContainerID.valueof(container.getContainerID()));
+ try {
+ if (container.getState() == LifeCycleState.OPEN) {
Review comment:
Pipeline scrubber only destroy pipeline that has been in ALLOCATED for too long. And the container loader only call addContainerToPipeline if the container is in OPEN state.
If I understand correctly, we should not have OPEN container assigned on an ALLOCATED pipeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org