You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by tolbertam <gi...@git.apache.org> on 2017/04/28 03:41:23 UTC
[GitHub] tinkerpop pull request #605: TINKERPOP-1671 Propagate exception to Future in...
GitHub user tolbertam opened a pull request:
https://github.com/apache/tinkerpop/pull/605
TINKERPOP-1671 Propagate exception to Future instead of calling thread
For [TINKERPOP-1671](https://issues.apache.org/jira/browse/TINKERPOP-1671)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tolbertam/tinkerpop TINKERPOP-1671
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/605.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #605
----
commit 63dd3d083bc47eda06bc7b074a6594b04a9fc7a8
Author: Andrew Tolbert <an...@datastax.com>
Date: 2017-04-28T03:39:53Z
TINKERPOP-1671 Propagate exception to Future instead of calling thread
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #605: TINKERPOP-1671 Propagate exception to Future instead o...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/605
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #605: TINKERPOP-1671 Propagate exception to Future in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/605
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #605: TINKERPOP-1671 Propagate exception to Future in...
Posted by tolbertam <gi...@git.apache.org>.
Github user tolbertam commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/605#discussion_r113846423
--- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/remote/RemoteConnection.java ---
@@ -67,7 +67,11 @@
// default implementation for backward compatibility to 3.2.4 - this method will probably just become
// the new submit() in 3.3.x when the deprecation is removed
final CompletableFuture<RemoteTraversal<?, E>> promise = new CompletableFuture<>();
- promise.complete(submit(bytecode));
+ try {
+ promise.complete(submit(bytecode));
+ } catch (Exception t) {
--- End diff --
Chose to limit to `Exception` types instead of `Throwable` since `RuntimeException`/`Error` are probably acceptable to be thrown on calling thread since they are unexpected and likely not caused by the traversal failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #605: TINKERPOP-1671 Propagate exception to Future instead o...
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/605
`docker/build.sh -i -t -n` success
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #605: TINKERPOP-1671 Propagate exception to Future instead o...
Posted by mpollmeier <gi...@git.apache.org>.
Github user mpollmeier commented on the issue:
https://github.com/apache/tinkerpop/pull/605
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---